Conversation
waldbauer-certat
force-pushed
the
fix-2162
branch
2 times, most recently
from
489c37b to
31f3512
Compare
waldbauer-certat
force-pushed
the
fix-2162
branch
from
31f3512 to
7f72b99
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## develop #2214 +/- ##
===========================================
- Coverage 76.33% 76.31% -0.03%
===========================================
Files 441 439 -2
Lines 23686 23652 -34
Branches 3747 3744 -3
===========================================
- Hits 18081 18050 -31
+ Misses 4865 4863 -2
+ Partials 740 739 -1
|
sebix
requested changes
Jul 15, 2022
Member
sebix
left a comment
sebix
left a comment
There was a problem hiding this comment.
Missing tests for the upgrade function
waldbauer-certat
force-pushed
the
fix-2162
branch
from
7f72b99 to
b56d559
Compare
sebix
approved these changes
Jul 25, 2022
Member
|
Rebase on develop to fix conflict |
Member
|
One unittest is failing with
We don't care. |
Fixes #2162 Signed-off-by: Sebastian Waldbauer <waldbauer@cert.at>
intelmq/tests/lib/test_upgrades.py was reformatted by @waldbauer-certat in 1eb14d6, fix the excludelines for codespell now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feed is discontinued, removing Parser, adding upgrade information.
Fixes #2162