Add JSON parser function to Jinja2 templates #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja2 has a JSON serializer, but not a parser. This is the source of many StackOverflow questions and bug reports to projects using Jinja2. Add a function "from_json", which just calls "json.loads", to templates so that they can handle the JSON string in the "output" field of an event.
waldbauer-certat
approved these changes
Oct 22, 2021
Contributor
waldbauer-certat
left a comment
waldbauer-certat
left a comment
There was a problem hiding this comment.
Looks good for me
ghost
added
component: bots
feature
ghost
self-assigned this
ghost
approved these changes
Oct 29, 2021
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our use cases, we sometimes have some JSON data that we want to format nicely for sending to another system via e-mail. We currently do that by having entire expert bots just to format the data into a string to go in the
outputfield of a message, which seems wasteful.With this patch, the Jinja2 template environment gains a function
from_json()(which just callsjson.loads()in the standard Python environment), meaning the Templated SMTP output bot can take strings containing JSON documents and do the formatting itself.