Skip to content

FIX: statistics_host returns if no host value is given #2104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 10, 2021
Merged

FIX: statistics_host returns if no host value is given #2104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions intelmq/lib/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ class Cache():

def __init__(self, host: str, port: int, db: str, ttl: int,
password: Optional[str] = None):
if host is None:
return
Comment on lines +27 to +28
Copy link

@ghost ghost Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is only applicable because the only code calling this cache is the bots.py for the statistics. If any other code would use this class, this fix silently ignores misconfiguration


if host.startswith("/"):
kwargs = {"unix_socket_path": host}

Expand Down