Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings-patterns.yml #41

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Conversation

l-vo
Copy link
Contributor

@l-vo l-vo commented Jan 12, 2019

Several answers are right

@lex111
Copy link
Member

lex111 commented Feb 6, 2019

Hi @l-vo

I checked the two regular expressions at https://regex101.com/, and it did not give a complete match, so now everything is correct and there is no need to fix anything.

@l-vo
Copy link
Contributor Author

l-vo commented Feb 6, 2019

So maybe it is the question that is not precise enough. A preg_match of the patterns [hp1-5]*\-.?or [a-z1-5\-]* will return true on the string PhP5-rocks. Therefore these two patterns matches too. The question don't talk about a complete or not match.

What do you think of changing the question by (pushed on the branch of the PR):

Which PCRE regular expression will match the totality of the string PhP5-rocks

@lex111
Copy link
Member

lex111 commented Feb 6, 2019

Maybe a little bit differently?

Which PCRE regular expression will match exactly the string PhP5-rocks

@l-vo
Copy link
Contributor Author

l-vo commented Feb 7, 2019

Question updated :)

@lex111 lex111 merged commit 45ac102 into certificationy:master Feb 7, 2019
@lex111
Copy link
Member

lex111 commented Feb 7, 2019

@l-vo awesome, thanks!

@l-vo l-vo deleted the patch-1 branch February 7, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants