Skip to content

Commit

Permalink
upd: edit comments
Browse files Browse the repository at this point in the history
  • Loading branch information
0xFustang committed Aug 28, 2024
1 parent 1d566cc commit 7d435fa
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/droid/platforms/ms_xdr.py
Original file line number Diff line number Diff line change
Expand Up @@ -434,8 +434,7 @@ def push_detection_rule(
pprint(response)

def parse_actions(self, actions, rule_file=None):
# This whole function is a mess
# It might be better to have a schema validation for the actions
# TODO: It might be better to have a schema validation for the actions
response_actions = []
for action in actions:
response_action = {}
Expand Down Expand Up @@ -539,7 +538,7 @@ def parse_actions(self, actions, rule_file=None):
)
raise
# And of course there is an exeption
# stopAndQuarantineFile needs deviceId as always, but in a comma separated list... MS Graph API is weird
# stopAndQuarantineFile needs deviceId as always, but in a comma separated list
if action_name == "stopAndQuarantineFile":
identifier += ",deviceId"
response_action["identifier"] = identifier
Expand Down

0 comments on commit 7d435fa

Please sign in to comment.