Nginx docs in README #3606
Merged
Nginx docs in README #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- nginx is now part of certbot-auto - apache is now cross-platform
bmw
requested changes
Oct 12, 2016
There was a problem hiding this comment.
Other than my comment about the link, this basically LGTM.
The one thing I will say is I think the section is a bit weird. In our list under the heading "Supports multiple web servers:", we list webroot and standalone as examples which are clearly not web servers. I think this section could be restructured a bit, but that can be in another PR.
| - webroot (adds files to webroot directories in order to prove control of | ||
| domains and obtain certs) | ||
| - nginx/0.8.48+ (highly experimental, not included in certbot-auto) | ||
| - standalone (runs its own simple webserver to prove you control a domain) | ||
| - other server software via ([https://certbot.eff.org/docs/using.html#third-party-plugins](third party plugins)) |
There was a problem hiding this comment.
This isn't the correct link syntax for a reStructuredText file. I'm sure you're familiar with the syntax here, but take a look at other links in this file for a reminder.
bmw
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.