test: add tests for truststore deterministic #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cert-manager-prow
bot
added
dco-signoff: yes
erikgb
force-pushed
the
test-truststore-deterministic
branch
from
cc18b23 to
5e549f4
Compare
SgtCoDFish
reviewed
Sep 24, 2024
SgtCoDFish
reviewed
Sep 24, 2024
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
erikgb
force-pushed
the
test-truststore-deterministic
branch
from
5e549f4 to
608d509
Compare
SgtCoDFish
approved these changes
Sep 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would still prefer if we could perform an unconditional SSA of target resources and avoid the complex and error-prone target "needs update" logic. This could eventually address #433 and in general, ensure trust-manager target resources are more up-to-date.
It seems like trust-manager truststores are now deterministic, except PKCS#12 truststores with a custom (non-empty) password. I attempted to fix this but didn't manage to.