[VC-35742] Handle canceled context to prevent extra retries#324
[VC-35742] Handle canceled context to prevent extra retries#324wallrj-cyberark wants to merge 1 commit intocert-manager:mainfrom
Conversation
…ries - Add logic to detect canceled context and avoid further reconcile attempts - Log context cancellation as info for diagnostics and apply patch before exit - Prevent logging expected context errors at error level during shutdown Signed-off-by: Richard Wall <richard.wall@cyberark.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @wallrj-cyberark. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@wallrj-cyberark normally, controller-runtime should have shutdown the queue resulting in no more retries after a context cancelation. There might be a slight delay, but that should not cause any issues afaik. |
xref:
/cc @FelixPhipps @inteon