Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks for issue 3618 #3621

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

jmhogan
Copy link
Contributor

@jmhogan jmhogan commented Mar 27, 2024

Closes #3618

Small updates to the MiniAOD getting started page for the new CMSSW10 container.

Also added a few links to the troubleshooting page to point people to the Guide and Forum. (#3452)

@jmhogan jmhogan requested a review from katilp March 27, 2024 20:01
Copy link
Member

@katilp katilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good, thanks! However, spotted out a typo (collsion) in the json file text that shows in the search view. It does not come automatically from the text but is in this line

It could be changed to correspond to the start of the text of the md (or just correct the typo).

Copy link
Member

@katilp katilp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

Small updates to the MiniAOD getting started page for the new CMSSW10
container.

Also added a few links to the troubleshooting page to point people to
the Guide and Forum. (cernopendata#3452)

Closes cernopendata#3618
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, rebased and squashed.

@tiborsimko tiborsimko merged commit 065d50e into cernopendata:qa Mar 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants