views: alias routes #2081
Closed
views: alias routes #2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atrisovic
added a commit
to atrisovic/opendata.cern.ch
that referenced
this pull request
Dec 11, 2017
* Closes: cernopendata#1130 * Addresses: cernopendata#2081 Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
ioannistsanaktsidis
requested changes
Dec 11, 2017
cernopendata/modules/pages/views.py
Outdated
| @@ -111,6 +111,7 @@ def md_debug(): | |||
|
|
|||
|
|
|||
| @blueprint.route('/visualise/events') | |||
| @blueprint.route('/visualize/events') | |||
There was a problem hiding this comment.
please check https://github.com/cernopendata/opendata.cern.ch/blob/master/cernopendata/modules/pages/views.py#L270 so as to avoid extra lines :)
cernopendata/modules/pages/views.py
Outdated
| @@ -122,7 +123,9 @@ def visualise_events_landing(): | |||
|
|
|||
|
|
|||
| @blueprint.route('/visualise/events/<string:experiment>') | |||
| @blueprint.route('/visualize/events/<string:experiment>') | |||
cernopendata/modules/pages/views.py
Outdated
| @blueprint.route('/visualise/events/<string:experiment>/<int:eventid>') | ||
| @blueprint.route('/visualize/events/<string:experiment>/<int:eventid>') |
cernopendata/modules/pages/views.py
Outdated
| @@ -138,7 +141,9 @@ def visualise_events(experiment='cms', eventid=None): | |||
|
|
|||
|
|
|||
| @blueprint.route('/visualise/histograms') | |||
| @blueprint.route('/visualize/histograms') | |||
cernopendata/modules/pages/views.py
Outdated
| @blueprint.route('/visualise/histograms/<string:experiment>') | ||
| @blueprint.route('/visualize/histograms/<string:experiment>') |
cernopendata/modules/pages/views.py
Outdated
| @@ -206,6 +211,7 @@ def about_cms_dataset_names(): | |||
| return redirect('/docs/cms-simulated-dataset-names') | |||
|
|
|||
|
|
|||
| @blueprint.route('/getstarted/<exp>') | |||
atrisovic
added a commit
to atrisovic/opendata.cern.ch
that referenced
this pull request
Dec 13, 2017
* Closes: cernopendata#1130 * Addresses: cernopendata#2081 Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
atrisovic
added a commit
to atrisovic/opendata.cern.ch
that referenced
this pull request
Dec 13, 2017
* Closes: cernopendata#1130 * Addresses: cernopendata#2081 Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
atrisovic
added a commit
to atrisovic/opendata.cern.ch
that referenced
this pull request
Dec 13, 2017
* Closes: cernopendata#1130 * Addresses: cernopendata#2081 Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
* Closes: cernopendata#1130 * Addresses: cernopendata#2081 Signed-off-by: Ana Trisovic <ana.trisovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ana Trisovic ana.trisovic@gmail.com