Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-date-picker] [terra-date-time-picker] Fixed DatePicker focus issues #2167

Merged
merged 7 commits into from
May 22, 2024
Merged

[terra-date-picker] [terra-date-time-picker] Fixed DatePicker focus issues #2167

merged 7 commits into from
May 22, 2024

Conversation

adavijit
Copy link
Collaborator

@adavijit adavijit commented May 19, 2024 •
edited
Loading

Summary

What was changed:

  • Focused the button to open calendar after calendar is closed in mobile view.
  • Introduced a new prop disableButtonFocusOnClose to optionally disable focusing the button when the calendar is closed.
  • Updated jest and wdio screenshots
  • Fixed DatePicker Input Field Tabbing issue

Why it was changed:

  • The onBlur event is not triggered in mobile view for date time picker because the focus is lost after the calendar is closed.
  • Pressing tab from a DateTime input fields should move to the next input field not to the calendar button.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10400 UXPLATFORM-10428

Thank you for contributing to Terra.
@cerner/terra

@adavijit adavijit changed the title UXPLATFORM-10428 Fixed DatePicker focus issue [terra-date-picker] [terra-date-time-picker] Fixed DatePicker focus issues May 20, 2024
@adavijit adavijit mentioned this pull request May 20, 2024
Closed
8 tasks
@adavijit adavijit self-assigned this May 20, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2167 May 21, 2024 09:06 Destroyed
@adavijit adavijit requested a review from saket2403 May 21, 2024 09:27
@sugan2416 sugan2416 merged commit 283f504 into main May 22, 2024
22 checks passed
@sugan2416 sugan2416 deleted the UXPLATFORM-10428 branch May 22, 2024 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saket2403 saket2403 saket2403 approved these changes

@sugan2416 sugan2416 sugan2416 approved these changes

Assignees

@adavijit adavijit

Labels
📦 terra-date-picker 📦 terra-date-time-picker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adavijit @sugan2416 @saket2403