This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-folder-tree] Increase radio button click target size #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycombs
commented
Apr 18, 2024
| @@ -133,16 +133,23 @@ const FolderTreeItem = ({ | |||
| ? <IconCaretDown height="8px" width="8px" style={{ verticalAlign: 'baseline' }} /> // eslint-disable-line react/forbid-component-props | |||
| : <IconCaretRight height="8px" width="8px" style={{ verticalAlign: 'baseline' }} />; // eslint-disable-line react/forbid-component-props | |||
|
|
|||
| /* eslint-disable jsx-a11y/click-events-have-key-events, jsx-a11y/no-noninteractive-element-interactions, jsx-a11y/label-has-associated-control */ | |||
There was a problem hiding this comment.
Trying to see if there is any change to avoid disabling these. For now these rules are all being disabled because:
- jsx-a11y/click-events-have-key-events - the onClick is only used to stop propagation and prevent expand/collapse, which is not an issue for the keyboard interactions
- jsx-a11y/no-noninteractive-element-interactions - this is just unavoidable as long as there is an onClick on a label.
- jsx-a11y/label-has-associated-control - not sure if a bug but in theory nesting label -> input the way is being done here should satisfy this rule, only disabling because none of the suggested solutions resolved the error
adoroshk
approved these changes
Apr 18, 2024
artpark
approved these changes
Apr 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change increases the size of the radio button click target to meet target size accessibility requirements so that users do not have to click inside a small radio button to select a row.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10097
Thank you for contributing to Terra.
@cerner/terra