Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Update terra-functional-testing to 4.0.0, updated ALL screenshots #3848

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

artpark
Copy link
Contributor

@artpark artpark commented Jul 13, 2023

Summary

What was changed:

Updated to consume the new version of terra-functional-testing (4.0.0).

A native select test also was updated due to an error. .getAttribute('value') -> .getValue()

Why it was changed:

For compatibility with Apple silicon devices.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@artpark artpark self-assigned this Jul 13, 2023
@artpark artpark requested a review from a team as a code owner July 13, 2023 20:53
@sdadn
Copy link
Contributor

sdadn commented Jul 13, 2023

Tested on Apple Silicon, all the WDIO tests pass:

CleanShot 2023-07-13 at 16 42 40@2x

@sdadn
Copy link
Contributor

sdadn commented Jul 13, 2023

@artpark Can you (or someone else) run the WDIO tests on intel and post a screenshot of them passing?

@JessieRandle
Copy link
Contributor

JessieRandle commented Jul 18, 2023

Screenshot 2023-07-18 at 10 08 18 AM

@sdadn Screenshot of tests passing on an intel device

@github-actions github-actions bot temporarily deployed to preview-pr-3848 July 18, 2023 19:05 Destroyed
@artpark artpark merged commit 4dbb620 into main Jul 18, 2023
@artpark artpark deleted the terra-functional-testing-4.0.0 branch July 18, 2023 20:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants