This repository has been archived by the owner on May 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 165
Removes change log entries for readme updates of broken links #3661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 7, 2022 07:02
Inactive
benbcai
reviewed
Sep 7, 2022
dangerfile.js
Outdated
@@ -15,6 +15,7 @@ changedFiles.forEach((file) => { | |||
} | |||
|
|||
const packageName = file.split('packages/')[1].split('/')[0]; | |||
console.log('file==>', file); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we intend to keep this console.log?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No !! will remove this 😄 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
benbcai
approved these changes
Sep 7, 2022
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 06:11
Inactive
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 06:24
Inactive
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 07:01
Inactive
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 09:34
Inactive
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 09:41
Inactive
neilpfeiffer
approved these changes
Sep 8, 2022
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 13:31
Inactive
JessieRandle
temporarily deployed
to
terra-core-cleanup-chan-renxqc
September 8, 2022 18:16
Inactive
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra