-
Notifications
You must be signed in to change notification settings - Fork 165
[terra-core-docs] Introducing terra-core-docs #3431
Changes from 6 commits
edecbe8
4992604
1f7e3be
27b6ea7
f3af0d3
471965c
3326f0f
3da7b6c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,9 +28,6 @@ | |
"dependencies": { | ||
"classnames": "^2.2.5", | ||
"prop-types": "^15.5.8", | ||
"terra-button": "^3.55.0", | ||
"terra-hyperlink": "^2.47.0", | ||
"terra-spacer": "^3.54.0", | ||
Comment on lines
-31
to
-33
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This right here is awesome, fewer dependencies, smaller component footprints. |
||
"terra-theme-context": "^1.0.0" | ||
}, | ||
"scripts": { | ||
|
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,30 +1,30 @@ | ||
Terra.describeViewports('ActionFooter', ['small', 'medium'], () => { | ||
it('displays ActionFooter with multiple end actions', () => { | ||
browser.url('/#/raw/tests/terra-action-footer/action-footer/multiple-end-action-footer'); | ||
browser.url('/raw/tests/terra-core-docs/action-footer/multiple-end-action-footer'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since tests are shipped with the component, does this mean terra-core-docs is expected to be installed for testing? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you'd need to yes, but i think we should discontinue the practice of shipping tests with components. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I had considered moving the wdio tests to the docs package as well, but I ended up not wanting to mess with how we currently can run just the tests for a specific package. |
||
|
||
Terra.validates.element('multiple end actions'); | ||
}); | ||
|
||
it('displays ActionFooter with multiple start actions', () => { | ||
browser.url('/#/raw/tests/terra-action-footer/action-footer/multiple-start-action-footer'); | ||
browser.url('/raw/tests/terra-core-docs/action-footer/multiple-start-action-footer'); | ||
|
||
Terra.validates.element('multiple start actions'); | ||
}); | ||
|
||
it('displays ActionFooter with single end action', () => { | ||
browser.url('/#/raw/tests/terra-action-footer/action-footer/single-end-action-footer'); | ||
browser.url('/raw/tests/terra-core-docs/action-footer/single-end-action-footer'); | ||
|
||
Terra.validates.element('single end action'); | ||
}); | ||
|
||
it('displays ActionFooter with single start action', () => { | ||
browser.url('/#/raw/tests/terra-action-footer/action-footer/single-start-action-footer'); | ||
browser.url('/raw/tests/terra-core-docs/action-footer/single-start-action-footer'); | ||
|
||
Terra.validates.element('single start action'); | ||
}); | ||
|
||
it('displays ActionFooter with single start and end action', () => { | ||
browser.url('/#/raw/tests/terra-action-footer/action-footer/single-start-end-action-footer'); | ||
browser.url('/raw/tests/terra-core-docs/action-footer/single-start-end-action-footer'); | ||
|
||
Terra.validates.element('single start and end action'); | ||
}); | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
package-lock=false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Changelog | ||
|
||
## Unreleased | ||
|
||
* Initial stable release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change will allow lerna ls to pickup private packages, which we want for compiling. we just don't want to release it yet.