This repository has been archived by the owner on May 24, 2024. It is now read-only.
Consume jest-config-terra #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhenkes
requested review from
dkasper-was-taken,
emilyrohrbough,
ryanthemanuel,
StephenEsser,
tbiethman and
yuderekyu
as code owners
mjhenkes
changed the title
StephenEsser
approved these changes
Mar 23, 2021
benbcai
reviewed
Mar 23, 2021
| @@ -11,6 +11,9 @@ | |||
| * Fixed `focus not getting removed` in IE for search and combobox variants. | |||
| * Fixed `focus not getting removed` in IE for multiple and tag variants. | |||
|
|
|||
| * Changed | |||
| * Updated Jest command | |||
There was a problem hiding this comment.
Do we want to combine this with the above Changed section or leave it like this to save a build?
benbcai
reviewed
Mar 23, 2021
Co-authored-by: Ben Cai <bcai@cerner.com>
benbcai
approved these changes
Mar 23, 2021
ryanthemanuel
approved these changes
Mar 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an example upgrade to the proposed jest-config-terra configuration package.
Notes on the added config:
The i18n package vicariously tests the output of terra-aggregate translations. With the jest-config-terra package no other package needs to run it before jest testing.
Enzyme setup is not included in jest-config-terra as I'm trying to be agnostic to the enzyme/testing-library:react debate and the jest config should be able to be used in no react modules without extraneous dependencies.
The jest config has clear mocks set to true, this uncovered at least one incorrect test that relied on a mocked value in a previous test.
I removed the file mock in favor of just using a string in the affected test files.
Deployment Link
https://terra-core-deployed-pr-#.herokuapp.com/
Testing
Additional Details
Thank you for contributing to Terra.
@cerner/terra