Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Commit

Permalink
[terra-button] Focus Glow getting cut off when used inside clinical h…
Browse files Browse the repository at this point in the history
…eader and table (#4040)
  • Loading branch information
MadanKumarGovindaswamy authored Feb 27, 2024
1 parent ee78a85 commit bbc1d5c
Show file tree
Hide file tree
Showing 503 changed files with 43 additions and 1 deletion.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 3 additions & 0 deletions packages/terra-button/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

* Changed
* Updated default margin value for terra-button.

## 3.74.0 - (February 15, 2024)

* Changed
Expand Down
2 changes: 1 addition & 1 deletion packages/terra-button/src/Button.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
font-size: var(--terra-button-font-size, 1rem);
justify-content: center;
line-height: var(--terra-button-line-height, 1.429);
margin: 0; /* Reset margin for Safari. Safari defaults to 2px. */
margin: 2px;
max-width: 100%; /* Need to help with overflow-wrap */
min-height: var(--terra-button-min-height, 2.14285rem);
outline: none;
Expand Down
8 changes: 8 additions & 0 deletions packages/terra-button/tests/wdio/button-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,4 +263,12 @@ Terra.describeViewports('Button', ['tiny'], () => {
Terra.validates.element('selected-button');
});
});

describe('Focusable button within table', () => {
it('displays focusable button within table', () => {
browser.url('/raw/tests/cerner-terra-core-docs/button/button-table');
browser.keys(['Tab', 'Tab']);
Terra.validates.element('button-table', { selector: '#table-button' });
});
});
});
1 change: 1 addition & 0 deletions packages/terra-core-docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
## 1.59.0 - (February 23, 2024)

* Added
* Added a test example for `terra-button` to validate focus inside table.
* Added test to `terra-section-header` for the sticky section header title.

## 1.58.0 - (February 20, 2024)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import React from 'react';
import Button from 'terra-button';
import Table, {
Header,
HeaderCell,
Body,
Cell,
Row,
} from 'terra-html-table';

const ButtonTable = () => (
<Table paddingStyle="compact" id="table-button">
<Header>
<HeaderCell key="NAME">Name</HeaderCell>
<HeaderCell key="ADDRESS">Address</HeaderCell>
</Header>
<Body>
<Row key="PERSON_0">
<Cell key="NAME"><><Button type="button" id="button1" isCompact aria-label="Alert" text="Alert 1" /></></Cell>
<Cell key="ADDRESS">123 Adams Drive</Cell>
</Row>
<Row key="PERSON_1">
<Cell key="NAME"><><Button type="button" id="button2" isCompact aria-label="Alert" text="Alert 2" /></></Cell>
<Cell key="ADDRESS">321 Drive Street</Cell>
</Row>
</Body>
</Table>
);

export default ButtonTable;
Loading

0 comments on commit bbc1d5c

Please sign in to comment.