Skip to content

fix: test the adapter-specific query ordering #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 10, 2023
Merged

fix: test the adapter-specific query ordering #1402

merged 5 commits into from
Mar 10, 2023

Conversation

@bf4
Copy link
Collaborator

@bf4 bf4 commented Feb 2, 2023

Extracted from #1400

Two tests related to this are still broken on MySQL

Failure:
Api::BoxesControllerTest#test_complex_includes_two_level [/home/runner/work/jsonapi-resources/jsonapi-resources/test/controllers/controller_test.rb:4166]:
Cache (mode: none) warmup response body must match normal response.
--- expected
+++ actual
@@ -83,7 +83,7 @@
          {\"self\"=>\"http://test.host/api/users/10001/relationships/things\",
           \"related\"=>\"http://test.host/api/users/10001/things\"},
         \"data\"=>
-         [{\"type\"=>\"things\", \"id\"=>\"10\"}, {\"type\"=>\"things\", \"id\"=>\"20\"}]}}},
+         [{\"type\"=>\"things\", \"id\"=>\"20\"}, {\"type\"=>\"things\", \"id\"=>\"10\"}]}}},
    {\"id\"=>\"10002\",
     \"type\"=>\"users\",
     \"links\"=>{\"self\"=>\"http://test.host/api/users/10002\"},


rails test controllers/controller_test.rb:4165

F

Failure:
Api::BoxesControllerTest#test_complex_includes_nested_things_secondary_users [/home/runner/work/jsonapi-resources/jsonapi-resources/test/controllers/controller_test.rb:4448]:
Cache (mode: none) warmup response body must match normal response.
--- expected
+++ actual
@@ -119,7 +119,7 @@
          {\"self\"=>\"http://test.host/api/users/10001/relationships/things\",
           \"related\"=>\"http://test.host/api/users/10001/things\"},
         \"data\"=>
-         [{\"type\"=>\"things\", \"id\"=>\"10\"}, {\"type\"=>\"things\", \"id\"=>\"20\"}]}}},
+         [{\"type\"=>\"things\", \"id\"=>\"20\"}, {\"type\"=>\"things\", \"id\"=>\"10\"}]}}},
    {\"id\"=>\"10002\",
     \"type\"=>\"users\",
     \"links\"=>{\"self\"=>\"http://test.host/api/users/10002\"},


rails test controllers/controller_test.rb:4447

@bf4 bf4 mentioned this pull request Feb 2, 2023
Merged
@bf4 bf4 force-pushed the fix_adapter_specific_tests branch from 50b1030 to 0b3852f Compare February 2, 2023 16:25
@bf4 bf4 force-pushed the fix_adapter_specific_tests branch from c1189ca to 6186618 Compare March 3, 2023 18:16
@bf4 bf4 merged commit 3cd93a2 into v0-11-dev Mar 10, 2023
@bf4 bf4 deleted the fix_adapter_specific_tests branch March 10, 2023 05:36
bf4
bf4 commented Mar 10, 2023
View reviewed changes
test/integration/requests/request_test.rb
pg = ENV['DATABASE_URL'].starts_with?('postgres')

if is_db?(:mysql)
skip "#{adapter_name} test expectations differ in insignificant ways from expected"
Copy link
Collaborator Author

@bf4 bf4 Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 🤷

lgebhardt pushed a commit that referenced this pull request Sep 19, 2023
@bf4 @lgebhardt
fix: test the adapter-specific query ordering (#1402)
f2bcba9 
* fix: test the adapter-specific query ordering
* test: make order independent
* test: sort order-dependent response
* test: skip failing mysql tests as ok for now
lgebhardt pushed a commit that referenced this pull request Apr 18, 2024
@bf4 @lgebhardt
fix: test the adapter-specific query ordering (#1402)
5868a37 
* fix: test the adapter-specific query ordering
* test: make order independent
* test: sort order-dependent response
* test: skip failing mysql tests as ok for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bf4