Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope related route names in a similar manner to relationship routes #1254

Merged
merged 1 commit into from
May 29, 2019

Conversation

lgebhardt
Copy link
Member

@lgebhardt lgebhardt commented May 29, 2019

This dodges an issue where the related route names might conflict with
index routes (e.g. a List that has_many :items, class_name: 'ListItem'
would have previously used list_items for the related resources and
conflict with the list_items index route for the ListItem class`)

cherry picked from 886cbe5 in release-09

Closes #1251

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

This dodges an issue where the related route names might conflict with
index routes (e.g. a List that `has_many :items, class_name: 'ListItem'`
would have previously used `list_items` for the related resources and
conflict with the `list_items` index route for the ListItem class`)

cherry picked from 886cbe5 in release-09
@lgebhardt lgebhardt merged commit b63e843 into master May 29, 2019
@lgebhardt lgebhardt deleted the related_scope branch June 20, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Related route name conflicts with class_name in 0.9.7
1 participant