Skip to content

fix regression in 0.9.5 server error when using filter with dot in name and custom applier #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

senid231
Copy link
Contributor

fixes #1214

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@senid231 senid231 force-pushed the 0-9-fix-filter-with-dot branch from 1ae2ddc to 1c9736d Compare January 21, 2019 12:56
@senid231 senid231 force-pushed the 0-9-fix-filter-with-dot branch from 1c9736d to 52607ff Compare January 21, 2019 13:14
lgebhardt pushed a commit that referenced this pull request Mar 25, 2019
@lgebhardt
Copy link
Member

@senid231 Thanks! I merged this with one minor change. Using try instead of &. to maintain compatibility with ruby versions earlier than 2.3. We don't officially support them, but I didn't want to lock someone out of the next 0.9 release.

@lgebhardt lgebhardt closed this Mar 25, 2019
@senid231 senid231 deleted the 0-9-fix-filter-with-dot branch March 25, 2019 18:19
@senid231
Copy link
Contributor Author

@lgebhardt thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants