Skip to content

Commit

Permalink
chore: Remove php 8.1 support (#67)
Browse files Browse the repository at this point in the history
Some of the newer dependencies don't support the `php 8.1`.
The active support for `8.1` is no longer present.
(https://www.php.net/supported-versions.php)

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
  • Loading branch information
oguzhand95 authored Dec 8, 2023
1 parent fd3e675 commit 32ba356
Show file tree
Hide file tree
Showing 4 changed files with 138 additions and 155 deletions.
55 changes: 51 additions & 4 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: [ '8.1', '8.2' ]
php-version: [ '8.2', '8.3' ]
experimental: [ false ]

steps:
Expand All @@ -35,13 +35,24 @@ jobs:
shell: bash
run: make lint

- name: Check repo status
shell: bash
run: |
repo_status=$(git status --porcelain)
if [[ ! -z "${repo_status}" ]]; then
echo "::error::Uncommitted changes detected"
echo "${repo_status}"
git status -vv
exit 1
fi
static-analysis:
name: Run static analysis
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php-version: [ '8.1', '8.2' ]
php-version: [ '8.2', '8.3' ]
experimental: [ false ]
steps:
- name: Checkout repository
Expand All @@ -61,6 +72,17 @@ jobs:
shell: bash
run: make static-analysis

- name: Check repo status
shell: bash
run: |
repo_status=$(git status --porcelain)
if [[ ! -z "${repo_status}" ]]; then
echo "::error::Uncommitted changes detected"
echo "${repo_status}"
git status -vv
exit 1
fi
validate-composer:
name: composer.json validation
runs-on: ubuntu-latest
Expand All @@ -72,14 +94,25 @@ jobs:
shell: bash
run: make validate-composer

- name: Check repo status
shell: bash
run: |
repo_status=$(git status --porcelain)
if [[ ! -z "${repo_status}" ]]; then
echo "::error::Uncommitted changes detected"
echo "${repo_status}"
git status -vv
exit 1
fi
unit-tests:
name: Run unit tests
needs: [ "lint" ]
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
php-version: [ '8.1', '8.2' ]
php-version: [ '8.2', '8.3' ]
experimental: [ false ]
steps:
- name: Checkout repository
Expand All @@ -100,4 +133,18 @@ jobs:

- name: Run unit tests
shell: bash
run: make test
run: make test

- name: Stop docker-compose
run: docker-compose down

- name: Check repo status
shell: bash
run: |
repo_status=$(git status --porcelain)
if [[ ! -z "${repo_status}" ]]; then
echo "::error::Uncommitted changes detected"
echo "${repo_status}"
git status -vv
exit 1
fi
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ This library requires the `gRPC` extension to be installed. Follow the [instruct

### PHP version requirements

The minimum supported version of PHP is `8.1`.
The minimum supported version of PHP is `8.2`.

### Simpler `CerbosClientBuilder`

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}
},
"require": {
"php": "^8.1 || ^8.2",
"php": "^8.2 || ^8.3",
"ext-grpc": "*",
"ext-json": "*",
"google/common-protos": "^4.1",
Expand Down
Loading

0 comments on commit 32ba356

Please sign in to comment.