Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Migrate to protovalidate #4

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

oguzhand95
Copy link
Member

@oguzhand95 oguzhand95 commented Sep 28, 2023

depends on cerbos/cerbos#1800

the validator.Validate cannot validate correctly because cerbos/cerbos#1800 has the newly generated code, while this module still being dependent on the previously generated code version.

Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@oguzhand95 oguzhand95 marked this pull request as ready for review September 28, 2023 14:11
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
cerbos/grpc.go Outdated Show resolved Hide resolved
Signed-off-by: Oğuzhan Durgun <oguzhandurgun95@gmail.com>
@charithe
Copy link
Contributor

charithe commented Oct 3, 2023

Merging without tests because there's a circular dependency with cerbos/cerbos#1800

@charithe charithe merged commit 0a48b82 into cerbos:main Oct 3, 2023
3 of 5 checks passed
@oguzhand95 oguzhand95 deleted the protovalidate branch October 3, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants