install-dependencies.sh: break long lines

Collect package lists into array variables, one element per line, for readability
and git-merge-ability.

install-dependencies.sh

@@ -19,29 +19,159 @@
 
 . /etc/os-release
 
+debian_packages=(
+    ninja-build
+    ragel
+    libhwloc-dev
+    libnuma-dev
+    libpciaccess-dev
+    libcrypto++-dev
+    libboost-all-dev
+    libxml2-dev
+    xfslibs-dev
+    libgnutls28-dev
+    liblz4-dev
+    libsctp-dev
+    gcc
+    make
+    libprotobuf-dev
+    protobuf-compiler
+    python3
+    systemtap-sdt-dev
+    libtool
+    cmake
+    libyaml-cpp-dev
+    libc-ares-dev
+    stow
+    g++
+)
+
+# seastar doesn't directly depend on these packages. They are
+# needed because we want to link seastar statically and pkg-config
+# has no way of saying "static seastar, but dynamic transitive
+# dependencies". They provide the various .so -> .so.ver symbolic
+# links.
+transitive=(libtool-ltdl-devel trousers-devel libidn2-devel libunistring-devel)
+
+redhat_packages=(
+    hwloc-devel
+    numactl-devel
+    libpciaccess-devel
+    cryptopp-devel
+    libxml2-devel
+    xfsprogs-devel
+    gnutls-devel
+    lksctp-tools-devel
+    lz4-devel
+    gcc
+    make
+    protobuf-devel
+    protobuf-compiler
+    systemtap-sdt-devel
+    libtool
+    cmake
+    yaml-cpp-devel
+    c-ares-devel
+    stow
+    "${transitive[@]}"
+)
+
+fedora_packages=(
+    "${redhat_packages[@]}"
+    gcc-c++
+    ninja-build
+    ragel
+    boost-devel
+    libubsan
+    libasan
+    libatomic
+)
+
+centos_packages=(
+    "${redhat_packages[@]}"
+    ninja-build
+    ragel
+    rh-mongodb36-boost-devel
+    devtoolset-8-gcc-c++
+    devtoolset-8-libubsan
+    devtoolset-8-libasan
+    devtoolset-8-libatomic
+)
+
+arch_packages=(
+    gcc
+    ninja
+    ragel
+    boost
+    boost-libs
+    hwloc
+    numactl
+    libpciaccess
+    crypto++
+    libxml2
+    xfsprogs
+    gnutls
+    lksctp-tools
+    lz4
+    make
+    protobuf
+    systemtap
+    libtool
+    cmake
+    yaml-cpp
+    stow
+)
+
+opensuse_packages=(
+    c-ares-devel
+    cmake
+    hwloc-devel
+    libboost_filesystem1_66_0
+    libboost_filesystem1_66_0-devel
+    libboost_program_options1_66_0
+    libboost_program_options1_66_0-devel
+    libboost_system1_66_0
+    libboost_system1_66_0-devel
+    libboost_test1_66_0
+    libboost_test1_66_0-devel
+    libboost_thread1_66_0
+    libboost_thread1_66_0-devel
+    libcryptopp-devel
+    libboost_atomic1_66_0
+    libboost_atomic1_66_0-devel
+    libboost_date_time1_66_0
+    libboost_date_time1_66_0-devel
+    libboost_chrono1_66_0
+    libboost_chrono1_66_0-devel
+    libgnutls-devel
+    libgnutlsxx28
+    liblz4-devel
+    libnuma-devel
+    lksctp-tools-devel
+    ninja protobuf-devel
+    ragel
+    xfsprogs-devel
+    yaml-cpp-devel
+    libtool
+    stow
+)
+
 if [ "$ID" = "ubuntu" ] || [ "$ID" = "debian" ]; then
-    apt-get install -y ninja-build ragel libhwloc-dev libnuma-dev libpciaccess-dev libcrypto++-dev libboost-all-dev libxml2-dev xfslibs-dev libgnutls28-dev liblz4-dev libsctp-dev gcc make libprotobuf-dev protobuf-compiler python3 systemtap-sdt-dev libtool cmake libyaml-cpp-dev libc-ares-dev stow g++
+    apt-get install -y "${debian_packages[@]}"
 elif [ "$ID" = "centos" ] || [ "$ID" = "fedora" ]; then
     if [ "$ID" = "centos" ]; then
         yum install -y epel-release centos-release-scl scl-utils
     fi
-    # seastar doesn't directly depend on these packages. They are
-    # needed because we want to link seastar statically and pkg-config
-    # has no way of saying "static seastar, but dynamic transitive
-    # dependencies". They provide the various .so -> .so.ver symbolic
-    # links.
-    transitive="libtool-ltdl-devel trousers-devel libidn2-devel libunistring-devel"
-
-    yum install -y hwloc-devel numactl-devel libpciaccess-devel cryptopp-devel libxml2-devel xfsprogs-devel gnutls-devel lksctp-tools-devel lz4-devel gcc make protobuf-devel protobuf-compiler systemtap-sdt-devel libtool cmake yaml-cpp-devel c-ares-devel stow $transitive
+
     if [ "$ID" = "fedora" ]; then
-        dnf install -y gcc-c++ ninja-build ragel boost-devel libubsan libasan libatomic
+        dnf install -y "${fedora_packages[@]}"
     else # centos
-        yum install -y ninja-build ragel rh-mongodb36-boost-devel devtoolset-8-gcc-c++ devtoolset-8-libubsan devtoolset-8-libasan devtoolset-8-libatomic 
+        yum install -y "${centos_packages[@]}" 
     fi
 elif [ "$ID" = "arch" -o "$ID_LIKE" = "arch" ]; then
-    pacman -Sy --needed gcc ninja ragel boost boost-libs hwloc numactl libpciaccess crypto++ libxml2 xfsprogs gnutls lksctp-tools lz4 make protobuf systemtap libtool cmake yaml-cpp stow
+    pacman -Sy --needed "${arch_packages[@]}"
 elif [ "$ID" = "opensuse-leap" ]; then
-    zypper install -y c-ares-devel cmake hwloc-devel libboost_filesystem1_66_0 libboost_filesystem1_66_0-devel libboost_program_options1_66_0 libboost_program_options1_66_0-devel libboost_system1_66_0 libboost_system1_66_0-devel libboost_test1_66_0 libboost_test1_66_0-devel libboost_thread1_66_0 libboost_thread1_66_0-devel libcryptopp-devel libboost_atomic1_66_0 libboost_atomic1_66_0-devel libboost_date_time1_66_0 libboost_date_time1_66_0-devel libboost_chrono1_66_0 libboost_chrono1_66_0-devel libgnutls-devel libgnutlsxx28 liblz4-devel libnuma-devel lksctp-tools-devel ninja protobuf-devel ragel xfsprogs-devel yaml-cpp-devel libtool stow
+    zypper install -y "${opensuse_packages[@]}"
 else
     echo "Your system ($ID) is not supported by this script. Please install dependencies manually."
     exit 1