rgw/admin: fix op-mask url parameter #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I Just realized that this PR overlaps with #1054. Were you aware of that? It might have been worthwhile to note that this covers the same topic but also has tests. |
Sorry, I didn't see that PR. |
phlogistonjohn
added
the
no-API
sj14
force-pushed
the
op-mask
branch
4 times, most recently
from
4c87dbe to
a5ce37b
Compare
Adjusted. |
phlogistonjohn
added
the
extended-review
phlogistonjohn
approved these changes
Apr 9, 2025
anoopcs9
approved these changes
Apr 11, 2025
|
@Mergifyio rebase |
When creating a user, the RGW expects the op-mask in the URL with a dash instead of an underscore as used for the JSON schema. Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>
✅ Branch has been successfully rebased |
phlogistonjohn
removed
the
extended-review
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The op-mask was not correctly transmitted when creating a user.
Checklist
//go:build ceph_previewmake api-updateto record new APIsNew or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.
The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with
@Mergifyiorebaseto rebase your PR when github indicates that the PR is out of date with the base branch.