nvme_gw_server: use dedicated rpc client for pings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't use the same client from different threads without some kind of protection, otherwise one thread may receive a response for a request sent by another thread. Signed-off-by: Mykola Golub <mykola.golub@clyso.com>
|
One may trigger this bug e.g. by running our pytest in loop: eventually it will fail (at least in my env). And although this PR fixes the problem with pings, it seems to me there is a potential issue when concurrent commands are sent from gw clients (e.g. cli) to the gw server, unless grpc_server_max_workers is set to 1. Though I have not investigated this case yet. |
PepperJo
approved these changes
May 19, 2022
|
@PepperJo I am going to create an issue for the multiple threads problem after I confirm it is indeed the issue. Right now it is just a suspicion. |
idryomov
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can't use the same client from different threads without some
kind of protection, otherwise one thread may receive a response
for a request sent by another thread.
Signed-off-by: Mykola Golub mykola.golub@clyso.com