Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case SPDK ping fails we exit with an OK exit code #914

Closed
gbregman opened this issue Oct 27, 2024 · 0 comments · Fixed by #916
Closed

In case SPDK ping fails we exit with an OK exit code #914

gbregman opened this issue Oct 27, 2024 · 0 comments · Fixed by #916
Assignees
@gbregman

Comments

@gbregman
Copy link
Contributor

There is no distinction in the gateway code between the case the gateway was brought down and the case it failed to ping the SPDK. In both cases the gateway exits with an OK exit code. We should make sure that in case of a ping failure the gateway exit code would be a failure. So it would get restarted.
@gbregman gbregman self-assigned this Oct 27, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Oct 27, 2024
@gbregman
Abort gateway in case of SPDK ping failure.
f72e3cd 
Fixes ceph#914

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
@gbregman gbregman mentioned this issue Oct 27, 2024
Merged
barakda pushed a commit to barakda/ceph-nvmeof that referenced this issue Oct 28, 2024
@gbregman @barakda
Abort gateway in case of SPDK ping failure.
4c0edaa 
Fixes ceph#914

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abort gateway in case of SPDK ping failure. gbregman/ceph-nvmeof
1 participant
@gbregman