Add _netdev as default mount options for both cepfs and rbd #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
requested review from
humblec,
nixpanic and
ShyamsundarR
and removed request for
humblec
Madhu-1
force-pushed
the
netdev
branch
2 times, most recently
from
1da5960 to
266663e
Compare
|
E2E is failing for LUKS encrypted PVC. will check can we pass |
Madhu-1
force-pushed
the
netdev
branch
2 times, most recently
from
264aa2a to
ea45337
Compare
dillaman
reviewed
Jan 24, 2020
This values will be added at both nodestage and nodepublish for rbd, nbd and ceph kernel client. As cephfs fuse doesnot support this value, this is added only during the nodepublish. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
`/run/mount` need to be share between host and csi-plugin containers for `/run/mount/utab` this is required to ensures that the network is not stopped prior to unmounting the network devices. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
ShyamsundarR
approved these changes
Jan 24, 2020
Mounting '/run' cause more issues related to udev, '/run/mount' what we need for netdev |
|
LGTM. Approved.. Thanks. |
humblec
approved these changes
Jan 28, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add _netdev as default mount options in plugins. This value will be added at both node stage and node publish for RBD, NBD and ceph kernel client.
As cephfs fuse doesn't support this value, this is added only during the node publish.
Add run host path to daemonset pods.
/run/mountneed to be shared between the host and csi-plugin containers for/run/mount/utabthis is required to ensure that the network is not stopped prior to unmounting the network devices.Signed-off-by: Madhu Rajanna madhupr007@gmail.com
Resolves #756