Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fixed broken links #4958

Merged
merged 1 commit into from
Nov 18, 2024
Merged

doc: fixed broken links #4958

merged 1 commit into from
Nov 18, 2024

Conversation

seadog007
Copy link
Contributor

@seadog007 seadog007 commented Nov 12, 2024 •
edited
Loading

Describe what this PR does

Fixed broken links for documents in 4 files.

Is there anything that requires special attention

Do you have any questions?
No

Is the change backward compatible?
No

Are there concerns around backward compatibility?
No

Provide any external context for the change, if any.
N/A

Related issues

Broken when #4907 merged
See also a6f1af4

Future concerns

N/A

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Nov 12, 2024
nixpanic
nixpanic previously approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@nixpanic nixpanic requested a review from a team November 13, 2024 08:17
@iPraveenParihar
Copy link
Contributor

Thanks for the PR.
Can you please fix the broken links at places as mentioned below?

  1. ceph-csi/charts/ceph-csi-cephfs/README.md

    Line 177 in 925ea19

    | `readAffinity.crushLocationLabels` | Define which node labels to use as CRUSH location. This should correspond to the values set in the CRUSH map. For more information, click [here](https://github.com/ceph/ceph-csi/blob/v3.9.0/docs/deploy-cephfs.md#read-affinity-using-crush-locations-for-cephfs-subvolumes)| `[]` |

  2. ceph-csi/charts/ceph-csi-rbd/README.md

    Line 190 in 925ea19

    | `readAffinity.crushLocationLabels` | Define which node labels to use as CRUSH location. This should correspond to the values set in the CRUSH map. For more information, click [here](https://github.com/ceph/ceph-csi/blob/v3.9.0/docs/deploy-rbd.md#read-affinity-using-crush-locations-for-rbd-volumes)| `[]` |

  3. ceph-csi/docs/resource-cleanup.md

    Lines 30 to 31 in 925ea19

    a. get omapkey (suffix of csi.volumes.default is value used for the CLI option
    [--instanceid](deploy-rbd.md#configuration) in the provisioner deployment.)

  4. ceph-csi/docs/resource-cleanup.md

    Line 59 in 925ea19

    a. remove rbd image(csi-vol-omapval, the prefix csi-vol is value of [volumeNamePrefix](deploy-rbd.md#configuration))

there was doc folder restructure PR #4907, @yati1998 can you please check for any other broken links that might need updating beyond those listed here?

seadog007 added a commit to seadog007/ceph-csi that referenced this pull request Nov 13, 2024
@seadog007
doc: fixed more broken links
ca3bf8f 
Requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <007seadog@gmail.com>
@mergify mergify bot dismissed nixpanic’s stale review November 13, 2024 11:10

Pull request has been modified.

yati1998
yati1998 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@yati1998 yati1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iPraveenParihar
Copy link
Contributor

@seadog007 Can you please squash your commits into one?

seadog007 added a commit to seadog007/ceph-csi that referenced this pull request Nov 15, 2024
@seadog007
doc: fixed broken doc links
8563c34 
The deploy link in the README is broken.
Fixed more broken links requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <007seadog@gmail.com>
seadog007 added a commit to seadog007/ceph-csi that referenced this pull request Nov 15, 2024
@seadog007
doc: fixed broken doc links
f55e115 
The deploy link in the README is broken.
Fixed more broken links requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <007seadog@gmail.com>
@mergify mergify bot dismissed yati1998’s stale review November 15, 2024 00:58

Pull request has been modified.

seadog007 added a commit to seadog007/ceph-csi that referenced this pull request Nov 15, 2024
@seadog007
doc: fixed broken doc links
55d85b9 
The deploy link in the README is broken.
Fixed more broken links requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <007seadog@gmail.com>
@seadog007
Copy link
Contributor Author

The commit has been squash into one

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Nov 18, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Nov 18, 2024

@Mergifyio rebase

@seadog007 @Madhu-1
doc: fixed broken doc links
99ed2c4 
The deploy link in the README is broken.
Fixed more broken links requested by iPraveenParihar in ceph#4958

Signed-off-by: 尤理衡 (Li-Heng Yu) <007seadog@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024

rebase

✅ Branch has been successfully rebased

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Nov 18, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 18, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at dc4ca20

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 18, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 18, 2024
@mergify mergify bot merged commit dc4ca20 into ceph:devel Nov 18, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@yati1998 yati1998 yati1998 left review comments

@nixpanic nixpanic Awaiting requested review from nixpanic

Assignees
No one assigned
Labels
bug Something isn't working ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@seadog007 @iPraveenParihar @Madhu-1 @ceph-csi-bot @nixpanic @yati1998