Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: move common functions for VolumeGroup structs into own type #4794

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Aug 21, 2024

Another PR that prepares for VolumeGroupSnapshot support. Refactoring common functions and attributes only, not introducing any functional change.

Many functions that are implemented for the volumeGroup type can be
shared with the (coming) volumeGroupSnapshot type. Move these functions
into a commonVolumeGroup type, so that volumeGroup and
volumeGroupSnapshot can inherit them.

@mergify mergify bot added the component/rbd Issues related to RBD label Aug 21, 2024
@nixpanic nixpanic force-pushed the rbd/commonVolumeGroup branch from 40205fd to b538d0f Compare August 22, 2024 11:32
@nixpanic nixpanic requested a review from a team August 22, 2024 11:40
@nixpanic nixpanic force-pushed the rbd/commonVolumeGroup branch from b538d0f to 11b4272 Compare August 23, 2024 09:11
@nixpanic nixpanic requested review from Madhu-1 and a team August 27, 2024 14:55
@Madhu-1 Madhu-1 requested a review from a team August 28, 2024 08:38
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 28, 2024

@Mergifyio queue

Copy link
Contributor

mergify bot commented Aug 28, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 689498e

Many functions that are implemented for the volumeGroup type can be
shared with the (coming) volumeGroupSnapshot type. Move these functions
into a commonVolumeGroup type, so that volumeGroup and
volumeGroupSnapshot can inherit them.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic nixpanic force-pushed the rbd/commonVolumeGroup branch from 11b4272 to 69c584f Compare August 28, 2024 09:45
@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Aug 28, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Aug 28, 2024
@mergify mergify bot merged commit 689498e into ceph:devel Aug 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rbd Issues related to RBD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants