rbd: add immediate topology flag (backport #4790) #4793
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
In csi-external-provisioner: v5.0.1, topology-aware provisioning is enabled by default. As a result provisioner now expects toologyKeys to be present in CSINode object which must be passed by user via `--domainlabels` flag in RBD nodeplugin. Issue: Users upgrading to v3.12.0 who were not previously using topology-aware provisioning may encounter issues when provisionining RBD PVCs, as the `--domainlabels` flag might not be set. Fix: To address this, add `--immediate-topology=false` to disable topology-aware provisioning. User requiring topology-aware provisioning should provided the volumeBindingMode as `WaitForFirstConsumer` and `TopologyConstrainedPools` as required in the StorageClass and configure `--domainlabels` flag in RBD nodeplugin. Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 55f221f)
Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit 9181d20)
mergify
bot
added
ok-to-test
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.30 |
|
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
Describe what this PR does
In csi-external-provisioner version 5.0.1, topology-aware provisioning is enabled by default. As a result, the provisioner now expects topologyKeys to be present in the CSINode object, which must be provided by the user via the
--domainlabelsflag in the RBD nodeplugin.Issue: Users upgrading to version 3.12.0 who were not previously using topology-aware provisioning may encounter issues when provisioning RBD PVCs, as the
--domainlabelsflag might not be set.Fix: To address this, add
--immediate-topology=falseto disable topology-aware provisioning. Users requiring topology-aware provisioning should provide the volumeBindingMode asWaitForFirstConsumerandTopologyConstrainedPoolsin the StorageClass and configure the--domainlabelsflag in the RBD nodeplugin.Fixes: #4777
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
This is an automatic backport of pull request #4790 done by [Mergify](https://mergify.com).