RBD: improvments to existing code to better align with volumegroup #4743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
force-pushed
the
implement-rbd-vg-mirror-1
branch
2 times, most recently
from
9316f1f to
09f91db
Compare
Madhu-1
force-pushed
the
implement-rbd-vg-mirror-1
branch
from
9131288 to
d2a3649
Compare
nixpanic
requested changes
Jul 31, 2024
Madhu-1
force-pushed
the
implement-rbd-vg-mirror-1
branch
from
d2a3649 to
5fd5244
Compare
nixpanic
approved these changes
Jul 31, 2024
Rakshith-R
approved these changes
Jul 31, 2024
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
updated GetVolumeByID to return more descriptive error so that caller no need to add more details in the error message. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
implement journalledObject interface to return the journal objects of the volume. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
This commit adds support for flattenMode option for volumegroup. If the flattenMode is set to "force" in volumegroupreplicationclass parameters, cephcsi will add a task to flatten the image if it has parent before adding it to the group. This enable cephcsi to then mirror such images after flattening them. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating HandleParentImageExistence function to return more details error which includes the pool/namespace/image name Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updating csiaddons spec to the latest main. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
in ModifyVolumeGroupMembership RPC call, flatten the required images before adding it to the group or else if the parent is not mirror enabled adding a child to the group will fail. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
GetVolumeByID already returning detailed error message, the caller just need to return it. No need to add duplicate details to error message. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
adding required ctx to the mirror interface as ctx is required for the volumegroup operations. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updated the group stringer method to have pool and namespace for proper debugging/logging and to use it with CLI as agrument as well. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
updated GetIDFromReplication to return volumeGroupID if its present. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Madhu-1
force-pushed
the
implement-rbd-vg-mirror-1
branch
from
5fd5244 to
0f4e55d
Compare
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the commits taken out of #4739 to make the other PR smaller. This contains lot of improvement which is going to help for future implementation and this also takes care of handling the flattening before adding the image to the group.