-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rbd: add VolumeGroup.ModifyVolumeGroupMembership CSI-Addons operation #4729
rbd: add VolumeGroup.ModifyVolumeGroupMembership CSI-Addons operation #4729
Conversation
The ModifyVolumeGroupMembership operation can be used to change the volumes that are part of a VolumeGroup. Only empty VolumeGroups can be removed, this operation is required to make that possible. Signed-off-by: Niels de Vos <ndevos@ibm.com>
There are no changes outside of |
} | ||
|
||
return &volumegroup.ModifyVolumeGroupMembershipResponse{ | ||
VolumeGroup: csiVG, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the other (csi-addons PR), do we really need to send a response with the volumegroup or just send an empty response similar to Delete operation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is like this in the specification of the CSI-Addons protocol for the operation, see https://github.com/csi-addons/spec/blob/main/volumegroup/README.md#modifyvolumegroupmembership.
The protocol that kubernetes-csi-addons uses to communicate between its Controller and sidecars can be different from the actual CSI-Addons Spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at a3d457a |
/test ci/centos/k8s-e2e-external-storage/1.27 |
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/k8s-e2e-external-storage/1.28 |
/test ci/centos/mini-e2e-helm/k8s-1.27 |
/test ci/centos/mini-e2e-helm/k8s-1.28 |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e/k8s-1.27 |
/test ci/centos/mini-e2e/k8s-1.28 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/k8s-e2e-external-storage/1.29 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.29 |
/test ci/centos/mini-e2e/k8s-1.29 |
The ModifyVolumeGroupMembership operation can be used to change the
volumes that are part of a VolumeGroup. Only empty VolumeGroups can be
removed, this operation is required to make that possible.
These logs contain the following actions: