Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csiaddons: update csi-addons spec #4692

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Jun 24, 2024

Updating the csi-addons spec and also switching to the source to get the replication volumeID and fallback to volumeId in the request if the volumeId is missing in the source

@Madhu-1 Madhu-1 added the ci/skip/e2e skip running e2e CI jobs label Jun 24, 2024
@Madhu-1 Madhu-1 requested review from a team June 24, 2024 11:04
@Madhu-1 Madhu-1 force-pushed the volume-group-rpc branch 5 times, most recently from 3d17145 to ec4192a Compare June 24, 2024 11:41
@nixpanic
Copy link
Member

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jun 24, 2024

rebase

✅ Nothing to do for rebase action

@Madhu-1 Madhu-1 force-pushed the volume-group-rpc branch from ec4192a to d47397b Compare June 24, 2024 12:55
update the csi-addons spec to the
latest commit.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 force-pushed the volume-group-rpc branch 4 times, most recently from 385930d to fa75166 Compare June 24, 2024 13:09
Madhu-1 added 2 commits June 24, 2024 15:12
read the volumeID from replication
source if the ID is missing read
it from req VolumeId as a fallback.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
replace csi-addons with csiaddons
as its causing the problem with
commitlint.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 force-pushed the volume-group-rpc branch from fa75166 to 50843c5 Compare June 24, 2024 13:14
@Madhu-1 Madhu-1 requested a review from nixpanic June 24, 2024 13:27
@Madhu-1 Madhu-1 changed the title csi-addons: update csi-addons spec csiaddons: update csi-addons spec Jun 24, 2024
@nixpanic nixpanic requested a review from a team June 24, 2024 15:03
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Jun 25, 2024

@Mergifyio queue

Copy link
Contributor

mergify bot commented Jun 25, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6d164fa

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Jun 25, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 25, 2024
@mergify mergify bot merged commit 6d164fa into ceph:devel Jun 25, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants