Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: close dir #4631

Merged
merged 1 commit into from
May 27, 2024
Merged

cephfs: close dir #4631

merged 1 commit into from
May 27, 2024

Conversation

testwill
Copy link
Contributor

@testwill testwill commented May 22, 2024 •
edited
Loading

Describe what this PR does

close /.snap directory

Is there anything that requires special attention

Do you have any questions?

Is the change backward compatible?

Are there concerns around backward compatibility?

Provide any external context for the change, if any.

For example:

  • Kubernetes links that explain why the change is required
  • CSI spec related changes/catch-up that necessitates this patch
  • golang related practices that necessitates this change

Related issues

Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.

Fixes: #issue_number

Future concerns

List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the bug Something isn't working label May 22, 2024
@iPraveenParihar
Copy link
Contributor

iPraveenParihar commented May 23, 2024 •
edited
Loading

@testwill, please format your commit message as per commit rules documented here

And also, the PR description

@Madhu-1 Madhu-1 added the component/cephfs Issues related to CephFS label May 23, 2024
@testwill testwill changed the title fix: close dir cephfs: close dir May 24, 2024
Rakshith-R
Rakshith-R previously approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@Rakshith-R Rakshith-R requested a review from a team May 27, 2024 05:50
Madhu-1
Madhu-1 previously approved these changes May 27, 2024
View reviewed changes
@Madhu-1 Madhu-1 added the backport-to-release-v3.11 Label to backport from devel to release-v3.11 branch label May 27, 2024
@Rakshith-R
Copy link
Contributor

@Mergifyio rebase
@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024

rebase

✅ Branch has been successfully rebased

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 27, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 27, 2024
@Rakshith-R
Copy link
Contributor

@testwill, please format your commit message as per commit rules documented here

And also, the PR description

@testwill Can you please sign off your commit as well ?

please refer to https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25443599508

Sorry, missed that test failure before adding queue command 🤦

@mergify mergify bot dismissed Madhu-1’s stale review May 27, 2024 06:56

Pull request has been modified.

@testwill
Copy link
Contributor Author

@Mergifyio rebase

Oh, I see rebase command is causing the problem with DCO check probably a new issue.

@testwill Can you please rebase it to latest manually ?

ok

@Rakshith-R Rakshith-R mentioned this pull request May 27, 2024
Closed
@testwill
cephfs: close dir
ec1f0c9 
Signed-off-by: guoguangwu <guoguangwug@gmail.com>
@Rakshith-R
Copy link
Contributor

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486
The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

@mergify mergify bot dismissed Rakshith-R’s stale review May 27, 2024 07:06

Pull request has been modified.

@testwill
Copy link
Contributor Author

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486 The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

I modified it

@Rakshith-R
Copy link
Contributor

/test ci/centos/mini-e2e-helm/k8s-1.29

@Rakshith-R
Copy link
Contributor

https://github.com/ceph/ceph-csi/pull/4631/checks?check_run_id=25444465486 The error also seems to point to two different names ?

Commit sha: 0d42f1e, Author: guangwu, Committer: Rakshith-R; Expected "guangwu guoguangwug@gmail.com", but got "guoguangwu guoguangwug@gmail.com".

I modified it

Thanks

@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 9574fa8

@iPraveenParihar iPraveenParihar added the ok-to-test Label to trigger E2E tests label May 27, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 27, 2024
@mergify mergify bot merged commit 9574fa8 into ceph:devel May 27, 2024
38 checks passed
@mergify mergify bot mentioned this pull request May 27, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

@Madhu-1 Madhu-1 Madhu-1 left review comments

Assignees
No one assigned
Labels
backport-to-release-v3.11 Label to backport from devel to release-v3.11 branch bug Something isn't working component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testwill @iPraveenParihar @Rakshith-R @ceph-csi-bot @Madhu-1