Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use Go 1.22 #4593

Merged
merged 4 commits into from
Apr 29, 2024
Merged

build: use Go 1.22 #4593

merged 4 commits into from
Apr 29, 2024

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Apr 29, 2024 •
edited
Loading

Kubernetes 1.30 packages require Go 1.22 or newer.

With a new Go version, golangci-lint reports more issues, these are addressed as well.

golangci-lint reports these:

The copy of the 'for' variable "kmsID" can be deleted (Go 1.22+)
(copyloopvar)

golangci-lint warns about this:

for loop can be changed to use an integer range (Go 1.22+)
(intrange)

gosec warns about it like this:

G601: Implicit memory aliasing in for loop. (gosec)

Related-to: #4569

nixpanic added 4 commits April 26, 2024 09:39
@nixpanic
build: use Go 1.22
af61009 
Kubernetes 1.30 packages require Go 1.22 or newer.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
build: address 'copyloopvar' linter warning
0fc86df 
golangci-lint reports these:

    The copy of the 'for' variable "kmsID" can be deleted (Go 1.22+)
    (copyloopvar)

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
build: address 'intrange' linter warning
cb334d0 
golangci-lint warns about this:

    for loop can be changed to use an integer range (Go 1.22+)
    (intrange)

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@nixpanic
build: address gosec warning "Implicit memory aliasing in for loop"
b318fa6 
gosec warns about it like this:

    G601: Implicit memory aliasing in for loop. (gosec)

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Apr 29, 2024
Rakshith-R
Rakshith-R requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this linter commit needs a another approach.

0fc86df

e2e/errors_test.go Show resolved Hide resolved
internal/cephfs/groupcontrollerserver_test.go Show resolved Hide resolved
internal/cephfs/nodeserver_test.go Show resolved Hide resolved
@nixpanic nixpanic requested a review from Rakshith-R April 29, 2024 11:35
@Rakshith-R Rakshith-R requested a review from a team April 29, 2024 11:57
@nixpanic
Copy link
Member Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 29, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 29, 2024
@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.28

@nixpanic
Copy link
Member Author

@Mergifyio requeue

@nixpanic
Copy link
Member Author

/retest ci/centos/mini-e2e-helm/k8s-1.28

Failed with a mismatch of backend images

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 29, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 6db7138 into ceph:devel Apr 29, 2024
40 checks passed
@iPraveenParihar iPraveenParihar mentioned this pull request Jun 3, 2024
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@yati1998 yati1998 yati1998 approved these changes

Assignees
No one assigned
Labels
component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nixpanic @ceph-csi-bot @yati1998 @Rakshith-R