helm: fix seLinuxMount option for csi driver object #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
component/deployment
yati1998
approved these changes
Mar 29, 2024
Rakshith-R
referenced
this pull request
Mar 29, 2024
Signed-off-by: Ruslan Khizhnyak <rkhizhnyak@ptsecurity.com>
|
@iPraveenParihar Can you document csidriver options in https://github.com/ceph/ceph-csi/tree/devel/charts/ceph-csi-rbd#configuration docs too(cephfs helm docs too) ? |
nixpanic
approved these changes
Mar 29, 2024
|
@Mergifyio rebase |
This commit fixes the typo from `.Values.seLinuxMount` to `.Values.CSIDriver.seLinuxMount` used in helm charts. Signed-off-by: Praveen M <m.praveen@ibm.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
helm/fix-selinux-option
branch
from
a729174 to
3c2659f
Compare
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 33a888f |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.29 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.29 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.29 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This commit fixes the typo from
.Values.seLinuxMountto.Values.CSIDriver.seLinuxMount.Values.selinuxMountis for adding mountPath/etc/selinux. Ref helm-charts: Add selinuxMount flag to enable/disable /etc/selinux host mount #2883Values.CSIDriver.seLinuxMountis for k8s efficient SELinux volume relabelling . Ref Add support & e2e for mountOptions & efficient selinux relabelling support #3902Checklist:
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)