Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update README.md with slack invite and channel links #4405

Merged
merged 3 commits into from
Feb 1, 2024
Merged

doc: Update README.md with slack invite and channel links #4405

merged 3 commits into from
Feb 1, 2024

Conversation

switchboardOp
Copy link
Contributor

@switchboardOp switchboardOp commented Jan 30, 2024 •
edited
Loading

Describe what this PR does

This MR updates the slack invite link in README.md with one provided by @nixpanic on the related issue and includes a direct link to the #ceph-csi channel therein.

Is there anything that requires special attention

nope

Related issues

Fixes: #4391

Future concerns

N/A

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@switchboardOp switchboardOp changed the title Update README.md with slack invite and channel links doc: Update README.md with slack invite and channel links Jan 30, 2024
@mergify mergify bot added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation labels Jan 30, 2024
karthik-us
karthik-us approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@karthik-us karthik-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

yati1998
yati1998 previously approved these changes Jan 31, 2024
View reviewed changes
nixpanic
nixpanic reviewed Jan 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@mergify mergify bot dismissed yati1998’s stale review January 31, 2024 15:34

Pull request has been modified.

nixpanic
nixpanic reviewed Jan 31, 2024
View reviewed changes
README.md
[#ceph-csi](https://ceph-storage.slack.com/archives/C05522L7P60) channel
on the [ceph Slack](https://ceph-storage.slack.com) to discuss anything
related to this project. You can join the Slack by this
[invite link](bit.ly/ceph-slack-invite)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For any others that wonder how to verify the link, you can add a + to the URL, like https://bit.ly/ceph-slack-invite+ to see where it points to.

nixpanic
nixpanic previously approved these changes Jan 31, 2024
View reviewed changes
@nixpanic nixpanic requested a review from yati1998 January 31, 2024 17:20
@mergify mergify bot dismissed nixpanic’s stale review January 31, 2024 17:43

Pull request has been modified.

@nixpanic
Copy link
Member

nixpanic commented Feb 1, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The pull request cannot be checked because of an incompatibility with branch protections.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@nixpanic
Copy link
Member

nixpanic commented Feb 1, 2024

@Mergifyio rebase

@switchboardOp @nixpanic
doc: Update README.md with slack invite and channel links
1b71945 
added updated invite link to the ceph slack workspace

Signed-off-by: Lucas Melchior <switchboard.op@gmail.com>
@switchboardOp @nixpanic
doc: 80 char per line
9941f50 
added shortened bit.ly link

Signed-off-by: Lucas Melchior <switchboard.op@gmail.com>
@switchboardOp @nixpanic
doc: remove trailing whitespace
e529927 
remove trailing whitespace

Signed-off-by: Lucas Melchior <switchboard.op@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 1, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 1, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 1, 2024
@mergify mergify bot merged commit 2217d10 into ceph:devel Feb 1, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@karthik-us karthik-us karthik-us approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/docs Issues and PRs related to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invite link to slack workspace is not active
5 participants
@switchboardOp @nixpanic @ceph-csi-bot @karthik-us @yati1998