Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added permission to get nodes for rbd (backport #4302) #4310

Merged
merged 2 commits into from
Dec 11, 2023
Merged

added permission to get nodes for rbd (backport #4302) #4310

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
394b424
helm: update node plugin cluster role
nemcikjan Dec 5, 2023
420d232
rbd: updated node labels fetching logic
nemcikjan Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
helm: update node plugin cluster role 
added permission to get nodes for rbd and cephfs nodeplugin daemonset

Signed-off-by: Jan Nemcik <jan.nemcik@solargis.com>
(cherry picked from commit 1fb6d8f)
  • Loading branch information
@nemcikjan @mergify
nemcikjan authored and mergify[bot] committed Dec 11, 2023
commit 394b4243e94d4a7bfb456af7cfbd66ffc5f8027c
2 changes: 0 additions & 2 deletions charts/ceph-csi-cephfs/templates/nodeplugin-clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ metadata:
heritage: {{ .Release.Service }}
{{- with .Values.commonLabels }}{{ toYaml . | trim | nindent 4 }}{{- end }}
rules:
{{- if and .Values.readAffinity .Values.readAffinity.enabled }}
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get"]
{{- end }}
{{- end -}}
2 changes: 0 additions & 2 deletions charts/ceph-csi-rbd/templates/nodeplugin-clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ metadata:
heritage: {{ .Release.Service }}
{{- with .Values.commonLabels }}{{ toYaml . | trim | nindent 4 }}{{- end }}
rules:
{{- if .Values.topology.enabled }}
- apiGroups: [""]
resources: ["nodes"]
verbs: ["get"]
{{- end }}
# allow to read Vault Token and connection options from the Tenants namespace
- apiGroups: [""]
resources: ["secrets"]
Expand Down