cephfs: enable read affinity #4153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
from
a7fdbdb to
a06de16
Compare
iPraveenParihar
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks if no further activity occurs. Thank you for your contributions. |
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
3 times, most recently
from
4d028e7 to
6b766e9
Compare
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
from
6b766e9 to
b1470fe
Compare
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
3 times, most recently
from
429c46c to
77a33c5
Compare
iPraveenParihar
changed the title
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
from
77a33c5 to
a1d198b
Compare
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
@Rakshith-R, looks like |
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
from
a1d198b to
128cf36
Compare
|
/test ci/centos/mini-e2e/k8s-1.28 |
Fuse might not support this option, you can to skip and log it in the nodeplugin. |
Rakshith-R
requested changes
Nov 22, 2023
docs/deploy-cephfs.md
Outdated
Comment on lines
234
to
235
| Refer [krbd-options](https://docs.ceph.com/en/latest/man/8/rbd/#kernel-rbd-krbd-options) | ||
| for more details. |
There was a problem hiding this comment.
This points to krbd mount options,
These read affinity mount options are not documented for cephfs kernel mounter. I'll ask for it to be documented at https://docs.ceph.com/en/latest/man/8/mount.ceph/#options.
Let's remove these two lines for now.
iPraveenParihar
force-pushed
the
cephfs/enable-read-affinity
branch
from
22fa0a8 to
a3ba54c
Compare
Rakshith-R
approved these changes
Nov 22, 2023
|
@Mergifyio rebase |
This commit makes use of crush location labels from node labels to supply `crush_location` and `read_from_replica=localize` options during mount. Using these options, cephfs will be able to redirect reads to the closest OSD, improving performance. Signed-off-by: Praveen M <m.praveen@ibm.com>
This commit adds --enable-read-affinity flag to enable read affinity for CephFS. Signed-off-by: Praveen M <m.praveen@ibm.com>
This commit adds documentation about read affinity supported for CephFS subvolumes. Signed-off-by: Praveen M <m.praveen@ibm.com>
✅ Branch has been successfully rebased |
Rakshith-R
force-pushed
the
cephfs/enable-read-affinity
branch
from
a3ba54c to
0cc6db9
Compare
nixpanic
approved these changes
Nov 22, 2023
|
@Mergifyio rebase |
✅ Nothing to do for rebase action |
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 00c12b3 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does
This commit makes use of crush location labels from node labels to supply
crush_locationandread_from_replica=localizeoptions during mount. Using these options, cephfswill be able to redirect reads to the closest OSD, improving performance.
Fixes: #4149
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)