Update mergify for 2 approvals/review for a PR.

[humblec]

Signed-off-by: Humble Chirammal hchiramm@redhat.com

[humblec]

@gman0 @Madhu-1 PTAL

[ShyamsundarR]

Arn't we closing this branch down in favor of master once we settle on #302 ? Asking, to understand why we are continuing to push PRs to this branch?

[Madhu-1]

till that PR can be merged on master with one approval, so we should take this PR in

[ShyamsundarR]

till that PR can be merged on master with one approval, so we should take this PR in

The question is more around whether we should be working on this branch at all, rather than the approval counts and such.

[Madhu-1]

till that PR can be merged on master with one approval, so we should take this PR in

The question is more around weather we should be working on this branch at all, rather than the approval counts and such.

as csiv1.0 is default branch which will be used for mergify
till we make master as default branch we should take PR related to build on this branch

[ShyamsundarR]

till that PR can be merged on master with one approval, so we should take this PR in

The question is more around weather we should be working on this branch at all, rather than the approval counts and such.

as csiv1.0 is default branch which will be used for mergify
till we make master as default branch we should take PR related to build on this branch

I would say remove mergify on the 1.0 branch and not take any more PRs as we are introducing breaking changes in the code that are not backward compatible. I believe we have discussed the same in a few forums. So, continuing the 1.0 branch and accepting PRs does not seem like the right thing to do.

[rootfs]

we currently don't have enough people with approval right, let's revisit this once we have enough reviewers

[humblec]

@Madhu-1 @ShyamsundarR Isnt it worh revisiting this PR ?

[Madhu-1]

@humblec AFAIK mergify works with default branch (master), we can leave this one

@ShyamsundarR any thoughts?

[ShyamsundarR]

@humblec AFAIK mergify works with default branch (master), we can leave this one

Yes, case in point PR #346 where Mergify waited for 2 approvals before a merge.

So I would say we can leave this out.

[Madhu-1]

closing as this is not required.