Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: remove old command main files #320

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

phlogistonjohn
Copy link
Contributor

Now that the unified binary has its own main file under "cmd/"
we no longer need the split main.go files.

Signed-off-by: John Mulligan jmulligan@redhat.com

Now that the unified binary has its own main file under "cmd/"
we no longer need the split main.go files.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@phlogistonjohn
Copy link
Contributor Author

Note: I noticed that that github tried to make "csi-v1.0" the parent branch, which wasn't what I used (master), so I changed it. However, if PRs are supposed to be filed against the csi-v1.0 branch first please let me know and I'll duplicate this. If not, we should consider changing the settings of the repo.

@ShyamsundarR
Copy link
Contributor

Note: I noticed that that github tried to make "csi-v1.0" the parent branch, which wasn't what I used (master), so I changed it. However, if PRs are supposed to be filed against the csi-v1.0 branch first please let me know and I'll duplicate this. If not, we should consider changing the settings of the repo.

The move to master is pending on PR #302 but all new PRs are to be posted against master.

@ShyamsundarR
Copy link
Contributor

@Madhu-1 @humblec @gman0 @leseb Request a review and if appropriate add the second approval for a merge. Thanks.

@humblec
Copy link
Collaborator

humblec commented Apr 24, 2019

@phlogistonjohn we have makefile targets all: rbdplugin cephfsplugin in place but I dont see targets. Dont we need to clean it up as well ?

@phlogistonjohn
Copy link
Contributor Author

Hi @humblec that issue was not introduced by this PR. It was introduced by one of my previous PRs and needs fixing but shouldn't block this pr. I will follow up with more fixes for the "unified" build approach.

@rootfs rootfs merged commit 327e814 into ceph:master Apr 26, 2019
@phlogistonjohn phlogistonjohn deleted the jjm-remove-old-main-files branch May 30, 2019 17:25
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants