replace gometalinter with golangci #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ShyamsundarR @rootfs @gman0 PTAL |
ShyamsundarR
reviewed
Mar 4, 2019
.travis.yml
Outdated
| @@ -31,9 +31,9 @@ jobs: | |||
| - pip install --user --upgrade pip | |||
| - pip install --user yamllint | |||
| # install gometalinter | |||
There was a problem hiding this comment.
(nit) comment needs a change
| --- | ||
| # This file contains all available configuration options | ||
| # with their default values. | ||
|
|
There was a problem hiding this comment.
Request you mention the source for this file and if any options are changed here? Helps change things in the future or catch up to later lint configuration changes as they happen.
gometalinter is being deprecated in favor of golangci. switching to golangci in ci and make test Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
rootfs
reviewed
Mar 4, 2019
| @@ -150,7 +150,7 @@ func (*NodeServer) mount(volOptions *volumeOptions, req *csi.NodeStageVolumeRequ | |||
|
|
|||
| klog.V(4).Infof("cephfs: mounting volume %s with %s", volID, m.name()) | |||
|
|
|||
| if err = m.mount(stagingTargetPath, cr, volOptions, volID); err != nil { | |||
There was a problem hiding this comment.
so this is unused param is found by golangci?
There was a problem hiding this comment.
yes it found during static check by golangci
rootfs
reviewed
Mar 4, 2019
| @@ -0,0 +1,153 @@ | |||
| --- | |||
| # https://github.com/golangci/golangci-lint/blob/master/.golangci.example.yml | |||
There was a problem hiding this comment.
would it be possible to curl this file instead of checking it in?
There was a problem hiding this comment.
the reference is taken from the linked file, and I have modified some values as per our requirement.
rootfs
approved these changes
Mar 4, 2019
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
replace gometalinter with golangci
nixpanic
pushed a commit
to nixpanic/ceph-csi
that referenced
this pull request
Mar 4, 2024
Syncing latest changes from upstream devel for ceph-csi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242