-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace gometalinter with golangci #245
Conversation
@ShyamsundarR @rootfs @gman0 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, just some minor nits from my end.
.travis.yml
Outdated
@@ -31,9 +31,9 @@ jobs: | |||
- pip install --user --upgrade pip | |||
- pip install --user yamllint | |||
# install gometalinter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) comment needs a change
--- | ||
# This file contains all available configuration options | ||
# with their default values. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request you mention the source for this file and if any options are changed here? Helps change things in the future or catch up to later lint configuration changes as they happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
gometalinter is being deprecated in favor of golangci. switching to golangci in ci and make test Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@@ -150,7 +150,7 @@ func (*NodeServer) mount(volOptions *volumeOptions, req *csi.NodeStageVolumeRequ | |||
|
|||
klog.V(4).Infof("cephfs: mounting volume %s with %s", volID, m.name()) | |||
|
|||
if err = m.mount(stagingTargetPath, cr, volOptions, volID); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this is unused param is found by golangci?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it found during static check by golangci
@@ -0,0 +1,153 @@ | |||
--- | |||
# https://github.com/golangci/golangci-lint/blob/master/.golangci.example.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be possible to curl this file instead of checking it in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reference is taken from the linked file, and I have modified some values as per our requirement.
replace gometalinter with golangci
Syncing latest changes from upstream devel for ceph-csi
Fixes #242