Markdown linter and spelling corrections. #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
Madhu-1
reviewed
Feb 6, 2019
| ``` | ||
|
|
||
| Deploys a daemon set with two containers: CSI driver-registrar and the CSI CephFS driver. | ||
|
|
||
| ## Verifying the deployment in Kubernetes | ||
|
|
||
| After successfuly completing the steps above, you should see output similar to this: | ||
| After successfully completing the steps above, you should see output similar to this: | ||
|
|
||
| ```bash | ||
| $ kubectl get all |
There was a problem hiding this comment.
need to remove $ here also
There was a problem hiding this comment.
No @Madhu-1 . The $ has to be removed only when there is no output
|
thanks @humblec there is a mention of kubernetes 1.11, can you make it 1.13 for this branch? |
Sure. I am updating the PR. |
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
|
@rootfs done. ptal. thanks ! |
rootfs
approved these changes
Feb 6, 2019
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
Markdown linter and spelling corrections.
karthik-us
pushed a commit
to karthik-us/ceph-csi
that referenced
this pull request
Aug 21, 2023
Revert "BUG 2225436: rbd: do not execute rbd sparsify when volume is in use"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Humble Chirammal hchiramm@redhat.com