Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown linter and spelling corrections. #174

Merged
merged 2 commits into from
Feb 6, 2019

Conversation

humblec
Copy link
Collaborator

@humblec humblec commented Feb 6, 2019

Signed-off-by: Humble Chirammal hchiramm@redhat.com

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Collaborator Author

humblec commented Feb 6, 2019

@rootfs @gman0 PTAL :)

```

Deploys a daemon set with two containers: CSI driver-registrar and the CSI CephFS driver.

## Verifying the deployment in Kubernetes

After successfuly completing the steps above, you should see output similar to this:
After successfully completing the steps above, you should see output similar to this:

```bash
$ kubectl get all
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove $ here also

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No @Madhu-1 . The $ has to be removed only when there is no output

@rootfs
Copy link
Member

rootfs commented Feb 6, 2019

thanks @humblec

there is a mention of kubernetes 1.11, can you make it 1.13 for this branch?

@humblec
Copy link
Collaborator Author

humblec commented Feb 6, 2019

thanks @humblec

there is a mention of kubernetes 1.11, can you make it 1.13 for this branch?

Sure. I am updating the PR.

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Collaborator Author

humblec commented Feb 6, 2019

@rootfs done. ptal. thanks !

@rootfs rootfs self-assigned this Feb 6, 2019
@rootfs rootfs self-requested a review February 6, 2019 13:43
@rootfs rootfs merged commit cb346a5 into ceph:csi-v1.0 Feb 6, 2019
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
Markdown linter and spelling corrections.
karthik-us pushed a commit to karthik-us/ceph-csi that referenced this pull request Aug 21, 2023
Revert "BUG 2225436: rbd: do not execute rbd sparsify when volume is in use"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants