Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update provisioner/attacher statefulsets #14

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Conversation

rootfs
Copy link
Member

@rootfs rootfs commented Feb 6, 2018

  • use k8scsi image
  • create plugin directory if not exist

Signed-off-by: Huamin Chen <hchen@redhat.com>
@rootfs
Copy link
Member Author

rootfs commented Feb 6, 2018

@sbezverk

@@ -66,7 +66,7 @@ spec:
serviceAccount: csi-attacher
containers:
- name: csi-attacher
image: csi_images/csi-attacher:latest
image: docker.io/k8scsi/csi-attacher:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it have to be k8scsi? It sounds more like k8 scsi :) maybe k8s-csi?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the repo registered by kubernetes-csi team :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, sounds good

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commentary explains the change is being made, but not why; could you add a "why" for other readers, @rootfs ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the image comes from here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and that's fine, but there's still no explanation of why the image location changed from csi_images/csi-attacher:latest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, thats a good point. csi_images is not at any public image registry, it is a local image used for development. For testing and production, the images have be hosted in a registry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@sbezverk sbezverk merged commit ce393c6 into ceph:master Feb 6, 2018
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
update provisioner/attacher statefulsets
nixpanic added a commit to nixpanic/ceph-csi that referenced this pull request Jan 14, 2021
KNIP-1542: RBD PV encryption using KMS type Hashicorp Vault
nixpanic pushed a commit to nixpanic/ceph-csi that referenced this pull request Sep 1, 2021
Sync red-hat-storage/ceph-csi:devel with ceph/ceph-csi:devel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants