-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update provisioner/attacher statefulsets #14
Conversation
rootfs
commented
Feb 6, 2018
- use k8scsi image
- create plugin directory if not exist
Signed-off-by: Huamin Chen <hchen@redhat.com>
@@ -66,7 +66,7 @@ spec: | |||
serviceAccount: csi-attacher | |||
containers: | |||
- name: csi-attacher | |||
image: csi_images/csi-attacher:latest | |||
image: docker.io/k8scsi/csi-attacher:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it have to be k8scsi? It sounds more like k8 scsi :) maybe k8s-csi?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the repo registered by kubernetes-csi team :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commentary explains the change is being made, but not why; could you add a "why" for other readers, @rootfs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the image comes from here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and that's fine, but there's still no explanation of why the image location changed from csi_images/csi-attacher:latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, thats a good point. csi_images
is not at any public image registry, it is a local image used for development. For testing and production, the images have be hosted in a registry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
update provisioner/attacher statefulsets
KNIP-1542: RBD PV encryption using KMS type Hashicorp Vault
Sync red-hat-storage/ceph-csi:devel with ceph/ceph-csi:devel