update provisioner/attacher statefulsets #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rootfs
commented
Feb 6, 2018
rootfs
commented
- use k8scsi image
- create plugin directory if not exist
Signed-off-by: Huamin Chen <hchen@redhat.com>
sbezverk
reviewed
Feb 6, 2018
| @@ -66,7 +66,7 @@ spec: | |||
| serviceAccount: csi-attacher | |||
| containers: | |||
| - name: csi-attacher | |||
| image: csi_images/csi-attacher:latest | |||
| image: docker.io/k8scsi/csi-attacher:latest | |||
There was a problem hiding this comment.
Does it have to be k8scsi? It sounds more like k8 scsi :) maybe k8s-csi?
There was a problem hiding this comment.
this is the repo registered by kubernetes-csi team :)
There was a problem hiding this comment.
The commentary explains the change is being made, but not why; could you add a "why" for other readers, @rootfs ?
There was a problem hiding this comment.
...and that's fine, but there's still no explanation of why the image location changed from csi_images/csi-attacher:latest
There was a problem hiding this comment.
Right, thats a good point. csi_images is not at any public image registry, it is a local image used for development. For testing and production, the images have be hosted in a registry.
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
update provisioner/attacher statefulsets
nixpanic
added a commit
to nixpanic/ceph-csi
that referenced
this pull request
Jan 14, 2021
KNIP-1542: RBD PV encryption using KMS type Hashicorp Vault
nixpanic
pushed a commit
to nixpanic/ceph-csi
that referenced
this pull request
Sep 1, 2021
Sync red-hat-storage/ceph-csi:devel with ceph/ceph-csi:devel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.