allow ceph mon stored in secret so when mon changes, cephfs driver can get latest mons and override old ones #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n get latest mons and override old ones Signed-off-by: Huamin Chen <hchen@redhat.com>
Signed-off-by: Huamin Chen <hchen@redhat.com>
gman0
reviewed
Jan 18, 2019
| @@ -40,7 +42,9 @@ func validateNonEmptyField(field, fieldName string) error { | |||
|
|
|||
| func (o *volumeOptions) validate() error { | |||
| if err := validateNonEmptyField(o.Monitors, "monitors"); err != nil { | |||
| return err | |||
| if err = validateNonEmptyField(o.MonValueFromSecret, "monValueFromSecret"); err != nil { | |||
There was a problem hiding this comment.
What if both monitors and monValueFromSecret are non-empty?
ceph-csi/pkg/cephfs/volumeoptions.go
Lines 103 to 107 in 3f196b5
From the code, it's obvious that monitors would take precedence but the documentation doesn't mention that.
There was a problem hiding this comment.
So IMHO either:
- add a simple check that those two options can't be specified at the same time, or
- add a comment in the docs that in case both of them are supplied,
monitorswill take precedence overmonValueFromSecret
There was a problem hiding this comment.
good points, i updated it. Now when monitors are set in the secret, controller and node server favor monValueFromSecret.
The rationale is that monitors, once set in storage class, are immutable. When monitors changes in the ceph cluster, existing PVs are no longer usable. In such case, a mutable setting in secret can solve this problem.
…e set Signed-off-by: Huamin Chen <hchen@redhat.com>
wilmardo
pushed a commit
to wilmardo/ceph-csi
that referenced
this pull request
Jul 29, 2019
allow ceph mon stored in secret so when mon changes, cephfs driver can get latest mons and override old ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gman0 this is a step to make the driver robust to ceph config changes