rbd: Handle maximum snapshots on a single rbd image #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuggupta27
reviewed
Jul 2, 2020
Madhu-1
force-pushed
the
snap-limit
branch
3 times, most recently
from
968b0eb to
9ca19c1
Compare
nixpanic
reviewed
Jul 2, 2020
Madhu-1
force-pushed
the
snap-limit
branch
3 times, most recently
from
1c8076d to
65016c7
Compare
humblec
previously approved these changes
Jul 2, 2020
Yuggupta27
reviewed
Jul 2, 2020
humblec
previously approved these changes
Jul 2, 2020
Madhu-1
force-pushed
the
snap-limit
branch
3 times, most recently
from
b6956c5 to
9eae500
Compare
nixpanic
reviewed
Jul 3, 2020
added listsnapshots function for an rbd image to list all the snapshots created from an rbd images, This will list the snapshots which are in trash also. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
nixpanic
previously approved these changes
Jul 3, 2020
|
/retest ci/centos/containerized-tests |
humblec
previously approved these changes
Jul 3, 2020
Added maxsnapshotsonimage flag to flatten the older rbd images on the chain to avoid issue in krbd.The limit is in krbd since it only allocate 1 4KiB page to handle all the snapshot ids for an image. The max limit is 510 as per https://github.com/torvalds/linux/blob/ aaa2faab4ed8e5fe0111e04d6e168c028fe2987f/drivers/block/rbd.c#L98 in cephcsi we arekeeping the default to 450 to reserve 10% to avoid issues. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
flatten cloned images to remove the link with the snapshot as the parent snapshot can be removed from the trash. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
as we need to test the maxsnapshotsonimage we need to set the limit to minimal value which we can test in CI as the default limit is 450,which cannot be tested in CI. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
mergify
bot
dismissed stale reviews from humblec and nixpanic
Pull request has been modified.
we need to take lock on parent rbd image when we are creating a snapshot from it, if the user tries to delete/resize the rbd image when we are taking snapshots,we may face issues. if the volume lock is present on the rbd image, the user cannot resize the rbd image nor delete the rbd image. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Moved e2e test timeout to build.env Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
moved deploy timeout from travis scripts to build.env Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
as we are creating more resources the e2e timeout is not enough we need to increase the e2e timeout to higher value for now. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Reduced the number of pods created in ROX E2E to save some time in E2E and changed the waiting time from 2 to 1 min. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
That would be my preference. We can then run tests in parallel and hopefully speed things up. I am still working to get the tests running in CentOS CI. Not sure when it is stable enough to replace some of the Travis CI jobs. |
nixpanic
approved these changes
Jul 3, 2020
humblec
approved these changes
Jul 6, 2020
|
/retest ci/centos/containerized-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have only a maximum of 510 snapshots on rbd images, due to the limitations mentioned in #1098. In CephCSI we are setting a limit of maximum 450 snapshots on an rbd image (keeping a buffer to avoid issues) During the SnapshotCreate RPC call we are creating a temporary snapshot and we create a clone from the snapshot and we delete the snapshot, Even if we delete the snapshot it will be in the trash as it's still linked to the cloned images, when we list all the snapshots
snap ls --allon an rbd image, it will show all the snapshots which are in the trash also. to remove the snapshots from the trash we need to remove the linking from cloned and the snapshots.As the cloned image is having the deep-flatten feature and once we flatten the cloned images which are created from the parent image, the temporary snapshots which are in the trash will be garbage collected, This will allow as to create more number of snapshots on a single rbd image.
closes #1098
updates: #1188