Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Helm chart for RBD plugin #108

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Added Helm chart for RBD plugin #108

merged 2 commits into from
Dec 12, 2018

Conversation

plnordquist
Copy link
Contributor

For my k8s cluster, I wrote a helm chart for the RBD deployment. Here's that helm chart, I didn't know where to put it in the tree but it should be easily moved.

Signed-off-by: Peter Nordquist <peter.nordquist@pnnl.gov>
@kfox1111
Copy link
Contributor

@sbezverk @rootfs

@rootfs
Copy link
Member

rootfs commented Dec 10, 2018

@kfox1111 thanks for the contribution, would you mind drafting a follow up doc PR? Just to show how install, load, and clean up the chart with some screenshot.

@@ -0,0 +1 @@
The Ceph RBD Container Storage Interface has been deployed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is printed to the screen when the chart is installed by helm. As an example, the metrics server chart prints how to use the metrics server data after you install it https://github.com/helm/charts/blob/master/stable/metrics-server/templates/NOTES.txt. I think this could be a place to stick information on how to use this chart, maybe a link to the examples section of this repo?

@rootfs
Copy link
Member

rootfs commented Dec 10, 2018

The chart looks good, some nits. I'll be mostly offline these days (I believe same for @sbezverk), please @gman0 for merge. Thanks!

@gman0
Copy link
Contributor

gman0 commented Dec 12, 2018

@plnordquist If you could add documentation for this under docs/ please, otherwise this LGTM, thanks!

@rootfs
Copy link
Member

rootfs commented Dec 12, 2018

@plnordquist please add a followup document PR. thanks!

@rootfs rootfs merged commit 27fa8a2 into ceph:master Dec 12, 2018
@plnordquist plnordquist deleted the rbd-chart branch January 7, 2019 16:28
wilmardo pushed a commit to wilmardo/ceph-csi that referenced this pull request Jul 29, 2019
Added Helm chart for RBD plugin
nixpanic pushed a commit to nixpanic/ceph-csi that referenced this pull request Jul 22, 2022
Bug 2099965: track metadata for RBD-images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants