driver: deploy csi-addons sidecar in its own DaemonSet #269
Conversation
There was a problem hiding this comment.
@black-dragon74 can you adjust the operator testing to enable csi-addons and verify extra daemonset for rbd?
This patch introduces a new DaemonSet for csi-addons sidecar that uses pod network instead of the host networking. Signed-off-by: Niraj Yadav <niryadav@redhat.com>
black-dragon74
force-pushed
the
csi-addons-podnet-ds
branch
from
eb7fdc3 to
7783af9
Compare
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
|
@nb-ohad PTAL |
|
In my testing, sometimes a deployment deadlock is reached due to strict pod anti-affinity rules (pods are unable to be scheduled on the same node as they are already running). This is leading to new replicaset always being in pending state, unless we go ahead and delete the old pods manually. To remedy this we should set maxSurge to 0. Discussing it here before including in this PR. |
This is not related to this PR right?
Are you testing on single node or multiplde node. Single node is not a big problem as its only for testing.
Is this related to this PR? we are using default what kubernetes provides and This is already configurable in the Driver CR unless am missing anything |
Correct. But we could have the updated strategy as a part of this PR itself. Since it is already in the review process. |
This is a different problem, it should have its own issue and one PR not as part of this one. |
Tracked at #273 |
Describe what this PR does
This patch introduces a new DaemonSet for csi-addons sidecar that uses pod network instead of the host networking.
Provide some context for the reviewer