Skip to content
This repository has been archived by the owner on May 6, 2021. It is now read-only.

Fixed viz tooltip position. #48

Merged
merged 3 commits into from
Nov 20, 2014

Conversation

karnan4ever
Copy link
Contributor

Fixes the position of tooltip that appears on top of the
hostgroups in workbench (sort by host).
Initially the tooltip always appears in the center of the screen and not
near the hostgroup, which is a ui bug.
Now the tooltip is placed exactly on the top of the host group using js absolute positioning.

Fixes: #7778

Signed-off-by: Karnan TC kchidamb@redhat.com

@dmick
Copy link
Member

dmick commented Sep 18, 2014

The "fixes" header needs to have the colon: "Fixes: #7778" (otherwise the link from redmine -> repo doesn't happen, and that's quite handy). Please fix that.

Also, please add a bit of explanatory text to the bug about what you found, why it was wrong, and why your fix fixes the issue, as it's not very obvious from the code change (even factoring in my inexperience with Javascript).

Otherwise, nice job.

@karnan4ever
Copy link
Contributor Author

Comment Updated.

@dmick
Copy link
Member

dmick commented Sep 19, 2014

And the bug?
On Sep 19, 2014 3:16 AM, "karnan4ever" notifications@github.com wrote:

Comment Updated.


Reply to this email directly or view it on GitHub
#48 (comment).

@karnan4ever
Copy link
Contributor Author

bug detail added.

@dmick
Copy link
Member

dmick commented Sep 23, 2014

I'm sorry to be a pest about this, karnan, but I don't see any addition to http://tracker.ceph.com/issues/7778 at all. ???

@ChristinaMeno
Copy link
Contributor

It looks like the absolute positioning doesn't work on smaller windows see screen shot in #7778

@karnan4ever karnan4ever force-pushed the fix-workbench-tooltip-7778 branch 2 times, most recently from 269557e to 31646cf Compare September 29, 2014 11:35
@karnan4ever
Copy link
Contributor Author

@GregMeno it is because of bug in rapheal js.
DmitryBaranovskiy/raphael#565

workaround made by adding a wrapper html div. now absolute positioning works relatively to the new div.
code updated.

@karnan4ever karnan4ever force-pushed the fix-workbench-tooltip-7778 branch from 07ce7b7 to 3d39909 Compare September 30, 2014 08:51
Fixes the position of tooltip that appears on top of the
hostgroups in workbench (sort by host).

Fixes #7778

Signed-off-by: Karnan TC <kchidamb@redhat.com>
The connectivity of hostgroup background is not proper.
Now, the position of last row osds are right aligned if it is an even row.

Fixes: #9521

Signed-off-by: Karnan TC <kchidamb@redhat.com>
@karnan4ever karnan4ever force-pushed the fix-workbench-tooltip-7778 branch from 3d39909 to 7a3ac92 Compare October 10, 2014 09:52
updates Mon to Monitors,
Updates PG to Placement Group.

Fixes: #9329
Signed-off-by: Karnan TC <kchidamb@redhat.com>
ChristinaMeno added a commit that referenced this pull request Nov 20, 2014
@ChristinaMeno ChristinaMeno merged commit de7bc85 into ceph:master Nov 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants