Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from SCA #154

Merged
merged 4 commits into from
May 29, 2018
Merged

Fixes from SCA #154

merged 4 commits into from
May 29, 2018

Conversation

dalgaaf
Copy link
Collaborator

@dalgaaf dalgaaf commented May 28, 2018

Some common fixes:

  • make single argument constructors explicit
  • mark some functions with override
  • init some variables in the init list for performance reasons

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Use explicit keyword for constructors with one argument to
prevent implicit usage as conversion functions.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@dalgaaf
Copy link
Collaborator Author

dalgaaf commented May 28, 2018

Again not sure if this really caused by the changes. It compiles fine and make check also works here (without the integration tests)

@jrse
Copy link
Contributor

jrse commented May 29, 2018

make check-valgrind fails, due to uninitialized member of RadosSaveLogEntry.
RadosSaveLogEntry(const std::string &oid_, const std::string &ns_, const std::string &pool_, const std::string &op_) : oid(oid_),
ns(ns),
pool(pool_),
op(op_) {}

the member ns is not properly initialized! little typo :-) (missing underline _)

you can re-check if you do make check-valgrind in the dovecot-ceph-plugin/src/tests directory.

@dalgaaf
Copy link
Collaborator Author

dalgaaf commented May 29, 2018

@jrse thanks for spotting this issue.

@jrse jrse merged commit 595e244 into master May 29, 2018
@dalgaaf dalgaaf deleted the wip-da-SCA-20180528 branch May 29, 2018 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants